Fix race when handling rapid succession of MQTT discovery messages#68785
Merged
Fix race when handling rapid succession of MQTT discovery messages#68785
Conversation
probot-home-assistant
bot
added
bugfix
core
has-tests
integration: mqtt
small-pr
balloob
approved these changes
Mar 28, 2022
jbouwh
approved these changes
Mar 29, 2022
| await super().async_added_to_hass() | ||
| self._prepare_subscribe_topics() | ||
| await self._subscribe_topics() | ||
| self.async_send_discovery_done() |
Contributor
There was a problem hiding this comment.
async_added_to_hass is overrided called from sensor and binary_sensor. These overrides should process the restore before calling super().async_added_to_hass
Contributor
There was a problem hiding this comment.
It might be async_added_to_hass is also called when a config_entry is added.
Contributor
There was a problem hiding this comment.
This seems no issue since self.async_send_discovery_done() is not doing anything when the entity is restored, only when it is discovered.
Contributor
Author
There was a problem hiding this comment.
The MQTT entities are only added when they are discovered.
emontnemery
force-pushed
the
mqtt_discovery_race
branch
from
68e178f to
9742fad
Compare
emontnemery
force-pushed
the
mqtt_discovery_race
branch
from
9742fad to
762bcaf
Compare
| """Verify event got called.""" | ||
| events.append(event) | ||
|
|
||
| hass.bus.async_listen(EVENT_STATE_CHANGED, callback) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix race when handling rapid succession of MQTT discovery messages
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: